Handle empty responses in timeline search#62
Merged
alex9smith merged 2 commits intomainfrom Mar 31, 2025
Merged
Conversation
Some timeline searches return no results - particularly those with a
short timespan. The API response when there's no results is simply `{}`
and not the `{"timeline": []}` that this library was expecting.
This meant users got a KeyError whenever they made a search that
returned new results.
I'm not clear if GDELT changed thier API response format since I
originally wrote the handling for the empty case or if this is simply a
long-running bug that's finally been brought to my notice and addressed.
Fixes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some timeline searches return no results - particularly those with a short timespan. The API response when there's no results is simply
{}and not the{"timeline": []}that this library was expecting.This meant users got a KeyError whenever they made a search that returned new results.
I'm not clear if GDELT changed thier API response format since I originally wrote the handling for the empty case or if this is simply a long-running bug that's finally been brought to my notice and addressed.
Fixes #58