Skip to content

Fixed the callback for init, now the remotes are ready before callback #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MasonBergstrom wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −10
Open

Fixed the callback for init, now the remotes are ready before callback #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c3728
Fixed the callback for init, now the remotes are ready before calling…
MasonBergstrom Aug 29, 2017
b29faad
Woops, that function doesn't need tobe addedas a global..
MasonBergstrom Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions lib/lirc_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ exports.init = function(callback) {

function irsendCallback(error, stdout, stderr) {
exports._populateRemotes(error, stdout, stderr);
exports._populateCommands();
if (callback) callback();
exports._populateCommands(callback);
}

return true;
Expand All @@ -39,14 +38,21 @@ exports._populateRemotes = function(error, stdout, stderr) {
});
};

exports._populateCommands = function() {
for (var remote in exports.remotes) {
(function(remote) {
exports.irsend.list(remote, '', function(error, stdout, stderr) {
exports._populateRemoteCommands(remote, error, stdout, stderr);
});
})(remote);
}
exports._populateCommands = function(callback) {
var remoteQ = [];
for (var remote in exports.remotes) {
remoteQ.push(remote);
}
var populate = function(remoteQ) {
if (remoteQ.length > 0) {
var remote = remoteQ.pop();
exports.irsend.list(remote, '', function(error, stdout, stderr) {
exports._populateRemoteCommands(remote, error, stdout, stderr);
populate(remoteQ);
});
} else if (typeof callback === "function") callback();
}
populate(remoteQ);
};

exports._populateRemoteCommands = function(remote, error, stdout, stderr) {
Expand Down