Start roadmap to 0.5.0 #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we didn't split concerns well given we had an explicit expiryTime to the cache interface. We invert the dependency here by storing and returning the createdAt timestamp when records are added to the cache. We also had a tight coupling on always importing the sqlite cache, even if you implement your own cache (i.e. redis, duckdb). Now, we split implementations of the cache into their own module, which can be imported if required. Business logic to check if a request/result is okay to store/return has been improved in transport.go as well. Overall improvements, but have removed tests for easier redesigning. Will (hopefully) add before the final release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.