Rewrite to support ArgHolder classes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 16, 2012 14:14
…is, adding test cases
…, since parsers need currentValue
Make argument parser more functional & various code cleanup
Preserve order of SelectInput options using LinkedHashSet
Add travis-ci for project
…p and LinkedHashSet).
Preserve order of SelectInput through parse operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alexy,
I don't really think you want to merge in this pull-request, but I just thought this was the best way to communicate w/ you about some derivative work which I have done.
I really liked the idea behind optional, but I wanted to be able to make command line arguments out of the fields of an object, rather than from the arguments to main(). But, though I forked from your code base, in the end I did a total rewrite. If you look, I think you'll see that both the usage and the internals are pretty different. (Eg., take a look at
https://github.com/squito/optional/blob/master/src/test/scala/optional/ObjectToArgsTest.scala
Given the differences, I'm leaning towards renaming my library, but I wanted to see if you had any opinion on it. (I'd still leave the reference to your work as the original inspiration.)
thanks,
Imran