Skip to content

Conversation

@pmhahn
Copy link
Contributor

@pmhahn pmhahn commented Jul 21, 2020

"Coveragepy noshow" and "... refresh" did have no effect for me.

Vim supports named group: https://vimhelp.org/sign.txt.html
Use them to group "[branch]uncovered" signs into them as it simplifies
clearing previous signs.

Switch "s:ClearSigns()" to use buffer number instead of file name.

This also makes #25 obsolete as it also clears the branchuncovered signs.

"Coveragepy noshow" and "... refresh" did have no effect for me.

Vim supports named group: <https://vimhelp.org/sign.txt.html>
Use them to group "[branch]uncovered" signs into them as it simplifies
clearing previous signs.

Switch "s:ClearSigns()" to use buffer number instead of file name.
@alfredodeza
Copy link
Owner

Thanks for the PR. I'd forgotten about this issue and had a local fix which I never pushed/released. Vim 8 changed the output of this:

let placements = split(execute('sign place file=' . bufname('%')), '\n')

And so the split() that followed was broken. I verified the groups change and it makes way more sense. Thanks!

@alfredodeza alfredodeza merged commit afcef30 into alfredodeza:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants