Skip to content

Corrected the Calculator power() function logic #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoelVR2k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Corrected the Calculator power() function logic #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions src/java/Calculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,26 +29,7 @@ public int subtract(int a, int b) {

//BUG: calling the in built power function in the user defined one makes no sense
public double power(double base, int exponent) {
if(exponent>0){
return powerHelper(base, exponent);
}
if(exponent==0){
return 1.0;
}
else {
if (exponent == Integer.MIN_VALUE) {
return 1.0/(base * powerHelper(base, Integer.MAX_VALUE));
} else {
return 1.0 /powerHelper(base, -exponent);
}
}
}
double powerHelper(double base, int exponent) {
double result = 1.0;
for (int i = 0; i < exponent; i++) {
result = result * base;
}
return result;
return Math.pow(base, exponent);
}

// TYPO: "sqare" instead of "square"
Expand Down