[PATCH] Remove Boost.Foreach dependency from project #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we build with C++14, we can use a std::const_reverse_iterator for the std::map instead of the BOOST_REVERSE_FOREACH macro. Also use std::vector::emplace_back to construct the new std::pair in-place, which eliminates an unnecessary copy/temporary value. Signed-off-by: Philipp Remy <philipp.remy@law-school.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we build with C++14, we can use a
std::const_reverse_iteratorfor thestd::mapinstead of theBOOST_REVERSE_FOREACHmacro.Also use
std::vector::emplace_backto construct the newstd::pairin-place, which eliminates an unnecessary copy/temporary.This removes all usages of Boost.Foreach from the project, making it no longer a required dependency.