[FIX] Handle endianness check for MSVC ARM[64] #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for detecting the endianness for pcg_uint128.hpp when compiling with MSVC and targeting ARM architectures. Windows on ARM requires code to be compiled in little-endian (see https://github.com/MicrosoftDocs/cpp-docs/blob/main/docs/build/arm64-windows-abi-conventions.md#endianness). This enables compiling CCTag on Windows on ARM. Signed-off-by: Philipp Remy <philipp.remy@law-school.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for detecting the target endianness required for
pcg_uint128.hppwhen compiling with MSVC and targeting ARM architectures.Windows on ARM requires code to be compiled in little-endian (see the Microsoft Documentation).
This enables compiling CCTag on Windows on ARM.