Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Dec 11, 2025

Why this PR ?

We miss a way to rename the node name. Node names are usually decided when we create the node by the graph part, but there is no way to set the name.
There is a label system that was used but that has only an impact on the display, it doesn't really changes the node name
Finally now if the name differs from the node type the node type is displayed on parenthesis :
image
I find this cleaner because previously it was the "default label" (so it would have been TestCLNode_N here)

Features implemented

Here is a gif that shows the new rename system
test_rename_node
another gif to show the update on the label
test_rename_node_2

  • double click on the node editor to rename
  • the name is changed
  • it is added in the GraphCommand so undo/redo should work
  • if the set name doesn't start with the node type (like "NodeType_") then the node type is precised in a label after
  • On the graph editor if no specific label is set, then the label is updated to the new node name

Special point of attention for reviewers

  • Compute/Submit : When the node is locked, the node renaming is supposed to be locked so this should prevent most issues
  • Graph editor : Renaming the node should set the correct label too
  • try to close/reopen meshroom to make sure everything works well

Remaining TODOs

  • add tests

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.82%. Comparing base (f7a48c9) to head (a417207).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/common/qt.py 16.66% 5 Missing ⚠️
meshroom/common/core.py 25.00% 3 Missing ⚠️
meshroom/core/graph.py 25.00% 3 Missing ⚠️
meshroom/core/node.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2953      +/-   ##
===========================================
- Coverage    78.91%   78.82%   -0.10%     
===========================================
  Files           59       59              
  Lines         8305     8320      +15     
===========================================
+ Hits          6554     6558       +4     
- Misses        1751     1762      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice added the feature new feature (proposed as PR or issue planned by dev) label Dec 12, 2025
@Alxiice Alxiice added this to the Meshroom 2026.1.0 milestone Dec 12, 2025
@servantftransperfect
Copy link
Contributor

  • There is no restriction on characters used. It accepts spaces, quotes, double quotes. did you test everything whenre there is those characters ?
  • When partially editing the name, nothing works well. (_1 is added each time, the label is kept empty, etc etc)

@Alxiice Alxiice force-pushed the dev/rename_node branch 4 times, most recently from 3c13f22 to abbc49f Compare January 8, 2026 14:11
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change is needed on the QML side, otherwise everything looks good to me!

I do think it'd be good to add some unit tests though, as it looks like a feature that may unintentionally break without realising it otherwise.

// Show node type if the node name does not start with "nodeType_"
Label {
text: "(" + root.displayNodeType + ")"
visible: root.displayNodeType !== ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
visible: root.displayNodeType !== ""
visible: root.displayNodeType !== "" && _reconstruction.selectedNode

Otherwise, if the last node that was selected is a node that has been renamed, the node type remains displayed in the NodeEditor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants