-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ui] Rename node #2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[ui] Rename node #2953
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2953 +/- ##
===========================================
- Coverage 78.91% 78.82% -0.10%
===========================================
Files 59 59
Lines 8305 8320 +15
===========================================
+ Hits 6554 6558 +4
- Misses 1751 1762 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
3c13f22 to
abbc49f
Compare
abbc49f to
a417207
Compare
cbentejac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change is needed on the QML side, otherwise everything looks good to me!
I do think it'd be good to add some unit tests though, as it looks like a feature that may unintentionally break without realising it otherwise.
| // Show node type if the node name does not start with "nodeType_" | ||
| Label { | ||
| text: "(" + root.displayNodeType + ")" | ||
| visible: root.displayNodeType !== "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| visible: root.displayNodeType !== "" | |
| visible: root.displayNodeType !== "" && _reconstruction.selectedNode |
Otherwise, if the last node that was selected is a node that has been renamed, the node type remains displayed in the NodeEditor.
Why this PR ?
We miss a way to rename the node name. Node names are usually decided when we create the node by the graph part, but there is no way to set the name.

There is a label system that was used but that has only an impact on the display, it doesn't really changes the node name
Finally now if the name differs from the node type the node type is displayed on parenthesis :
I find this cleaner because previously it was the "default label" (so it would have been
TestCLNode_Nhere)Features implemented
Here is a gif that shows the new rename system


another gif to show the update on the label
GraphCommandso undo/redo should workSpecial point of attention for reviewers
Remaining TODOs