Skip to content

Comments

From store docs fix#102

Closed
connorff wants to merge 2 commits intoalienzhou:masterfrom
connorff:fromStore-docs-fix
Closed

From store docs fix#102
connorff wants to merge 2 commits intoalienzhou:masterfrom
connorff:fromStore-docs-fix

Conversation

@connorff
Copy link

@connorff connorff commented Aug 6, 2022

I was looking through the docs and noticed an inconsistency in the order of parameters to the fromStore call. Based on the function definition, the order of the parameters is startMeta endMeta, text, id, and extra. This is called correctly in the complex example section but not in the usage section.

This PR updates the parameters to the correct order in the usage section.

@connorff
Copy link
Author

connorff commented Aug 6, 2022

Ah I notice #100 does the same thing. Feel free to close this in favor of theirs. Although this PR updates both language's READMEs.

@connorff connorff closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant