Skip to content

Revive Boxify for Xcode 9.1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p-sun wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revive Boxify for Xcode 9.1 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10d8ddb
Upgrade to the latest Swift 4 for Xcode 9.1.
p-sun Nov 26, 2017
34814fe
Upgrade to the latest recommended settings to silence Xcode warning.
p-sun Nov 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Boxify.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0900;
LastUpgradeCheck = 0900;
LastUpgradeCheck = 0910;
ORGANIZATIONNAME = "Alun Bestor";
TargetAttributes = {
9FFE39131EF1DE2500D26EB8 = {
Expand Down Expand Up @@ -206,6 +206,8 @@
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Expand Down Expand Up @@ -261,6 +263,8 @@
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
Expand Down
10 changes: 5 additions & 5 deletions Boxify/Utilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ extension UIImage {
guard let ciImage = CIImage(image: self) else {
return nil
}
return UIImage(ciImage: ciImage.applyingFilter("CIColorInvert", withInputParameters: nil))
return UIImage(ciImage: ciImage.applyingFilter("CIColorInvert"))
}

static func composeButtonImage(from thumbImage: UIImage, alpha: CGFloat = 1.0) -> UIImage {
Expand Down Expand Up @@ -344,9 +344,9 @@ extension ARSCNView {
let maxAngleInDeg = min(coneOpeningAngleInDegrees, 360) / 2
let maxAngle = ((maxAngleInDeg / 180) * Float.pi)

let points = features.points
let points = features.__points

for i in 0...features.count {
for i in 0...features.__count {

let feature = points.advanced(by: Int(i))
let featurePos = SCNVector3(feature.pointee)
Expand Down Expand Up @@ -416,13 +416,13 @@ extension ARSCNView {
return nil
}

let points = features.points
let points = features.__points

// Determine the point from the whole point cloud which is closest to the hit test ray.
var closestFeaturePoint = origin
var minDistance = Float.greatestFiniteMagnitude

for i in 0...features.count {
for i in 0...features.__count {
let feature = points.advanced(by: Int(i))
let featurePos = SCNVector3(feature.pointee)

Expand Down
2 changes: 1 addition & 1 deletion Boxify/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class ViewController: UIViewController, ARSCNViewDelegate, UIGestureRecognizerDe
super.viewWillAppear(animated)

// Create a session configuration
let configuration = ARWorldTrackingSessionConfiguration()
let configuration = ARWorldTrackingConfiguration()
configuration.planeDetection = .horizontal

// Run the view's session
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This is an ARKit project that demonstrates drawing out a 3-dimensional box in the world, which can be rotated and resized from each of its faces.

### Requirements
1. XCode 9 (or newer)
1. XCode 9.1 (or newer)
2. [One of the following devices (or newer) running iOS 11 (or newer)](http://wccftech.com/heres-the-list-of-iphone-models-compatible-with-the-arkit-in-ios-11/):
- The 2017 9.7-inch iPad
- All three variants of the iPad Pro
Expand Down