Skip to content

Remove HttpClientContext from message parameters because it's not referenced in the message template #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bati06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove HttpClientContext from message parameters because it's not referenced in the message template #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions samples/Serilog.HttpClient.Samples.ConsoleApp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class Program
{
static void Main(string[] args)
{
Serilog.Debugging.SelfLog.Enable(Console.Error);

Serilog.Log.Logger = new LoggerConfiguration()
.WriteTo.File(new JsonFormatter(),$"log-{DateTime.Now:yyyyMMdd-HHmmss}.json")
.WriteTo.Console(outputTemplate:
Expand Down
2 changes: 1 addition & 1 deletion src/Serilog.HttpClient/RequestLoggingOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ private static LogEntryParameters DefaultLogMessageAndProperties(HttpClientConte
return new LogEntryParameters()
{
MessageTemplate = "HTTP Client {RequestMethod} {RequestPath} responded {StatusCode} in {ElapsedMilliseconds:0.0000} ms",
MessageParameters = new object[]{ h.Request.Method, h.Request.Path, h.Response.StatusCode, h.Response.ElapsedMilliseconds, h},
MessageParameters = new object[]{ h.Request.Method, h.Request.Path, h.Response.StatusCode, h.Response.ElapsedMilliseconds},
AdditionalProperties = { ["Context"] = h }
};
}
Expand Down