Add From<u8> and From<char> to Quotable (alternative implementation)#25
Open
Add From<u8> and From<char> to Quotable (alternative implementation)#25
From<u8> and From<char> to Quotable (alternative implementation)#25Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23, but
u8/charonly; not iterator. Adding iterator support results in conflicting impls. The ergonomics of more generality are poor in this instance. This is one of two alternative implementations (the other is #24). I'm not sure which I want to merge, or if I want to merge either of them.