Upgrade to webpack 4. #111
Conversation
| "node": "6.11.4", | ||
| } | ||
| }, | ||
| "modules": "commonjs", |
There was a problem hiding this comment.
for some reason, this is the only way I could get the tests to work?! I don't understand why it wasn't necessary for the cli.
| At this point contribution guidelines are limited. This document contains information on setting up and developing locally; otherwise the primary concern for contributors is whether or not you are a member of the Alley Interactive organization (Huron's sponsor). | ||
|
|
||
| ## Development | ||
| There are two primary comonents to Huron: the CLI and the web (browser) script. Since each of these is used for different purposes, there is a different build pipeline for each. |
There was a problem hiding this comment.
All changes in this file are correcting typos
package.json
Outdated
| "handlebars": "^4.0.11", | ||
| "handlebars-loader": "^1.7.0", | ||
| "html-loader": "^0.5.5", | ||
| "html-webpack-plugin": "jantimon/html-webpack-plugin#webpack-4", |
There was a problem hiding this comment.
:shakes-fist: jantimon/html-webpack-plugin#860 (comment)
Breaking change with earlier versions of webpack.
goodguyry
left a comment
goodguyry
left a comment
There was a problem hiding this comment.
The inconsistency in console statements' formatting (single-line vs. multi-line) bothers me, but it's obviously non-blocking. Sweet update! 🥇
| "plugins": [ | ||
| "jest" | ||
| ], | ||
| // Do NOT change these rules |
config/webpack.browser.config.js
Outdated
| }, | ||
| { | ||
| test: /\.js$/, | ||
| // exclude: /node_modules/, |
There was a problem hiding this comment.
🤔 We don't need to exclude node_modules for either of these? If not, I'd say I'd say kill this comment.
There was a problem hiding this comment.
we do, this was me debugging, I'm adding it back, good catch 😅
src/cli/actions.js
Outdated
| chalk.red(`Could not delete: ${file.name}`) | ||
| ); | ||
| console.warn( | ||
| chalk.red(`Could not delete: ${file.name}`)); |
There was a problem hiding this comment.
Should this still be broken out in a separate line?
|
|
||
| if (prototype.length) { | ||
| id = prototype[0]; | ||
| [id] = prototype; |
src/cli/server.js
Outdated
| info.errors | ||
| ) | ||
| ); | ||
| console.error(chalk.red( |
| // Requires | ||
| /** @global */ | ||
|
|
||
| // @todo this may be deprecated with webpack 4 |
There was a problem hiding this comment.
There still are some places where we are parsing for env.huron so it's not completely but we probably should look at a more webpack 4 way of approaching this.
| 'Webpack encountered warnings during compile: ', info.warnings | ||
| ) | ||
| ); | ||
| console.error(chalk.yellow('Webpack encountered warnings during compile: ', info.warnings)); // eslint-disable-line max-len |
The directory system not working with the WP implementation that requires a single JSON manifest.
…x-for-postcss-modules
Refactor css modules implementation to point to one file, not a directory
No description provided.