Fix critical unit conversion bug in water access calculations#9
Merged
Fix critical unit conversion bug in water access calculations#9
Conversation
- Fix critical unit conversion bug in gis_global_module.py * Velocity data is in m/s but was treated as km/h * Added proper conversion factor (3600/1000) to distance calculations * This fixes the 3.6x underestimation of water access distances - Update sensitivity analysis MET value from 3.5 to 4.5 - Add better error handling for mobility model results Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Bug
The velocity data from the mobility models is in meters per second (m/s) but the distance calculation formula was treating it as kilometers per hour (km/h). This missing unit conversion caused all water access distances to be 3.6x smaller than they should be.
Evidence
The Fix
Added the proper unit conversion factor
* 3600 / 1000to convert m/s velocities to km distances:Changes
Impact
This fix corrects a fundamental calculation error that affected all water access distance estimates in the global model.
🤖 Generated with Claude Code