Skip to content

Conversation

@iksteen
Copy link

@iksteen iksteen commented Sep 30, 2014

You might not want to merge this as the original code is prettier, but I needed this patch to make it work on some older machines that only have python 2.5. So I thought I'd share it with you anyway.

It changes the @.setter syntax to the old = property(getter, setter) syntax.

Change the @<property>.setter constructs to
<property> = property(getter, setter)
@allfro
Copy link
Owner

allfro commented Sep 30, 2014

Thanks! I'll take a look at it and see if we can integrate both versions
somehow. Worst case scenario we create a different branch for 2.5.

On Tuesday, September 30, 2014, Ingmar Steen notifications@github.com
wrote:

You might not want to merge this as the original code is prettier, but I
needed this patch to make it work on some older machines that only have
python 2.5. So I thought I'd share it with you anyway.

It changes the @.setter syntax to the old = property(getter, setter)

syntax.

You can merge this Pull Request by running

git pull https://github.com/voipro/pcappy fix-python25

Or view, comment on, or merge it at:

#1
Commit Summary

  • Make R/W properties compatible with Python 2.5.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants