Template Haskell for consul-haskell client #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shim of the internal API. Have excised the old code, and am working on determining the parse tree and constructing it in TH.
Changed .cabal file to include template-haskell dependency. Had to move some code around because TH requires that any arguments to TH functions come from an import. Deleting unused files.
Member
|
Can you have a look at the test/build failures? https://travis-ci.org/alphaHeavy/consul-haskell/builds/84446673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steve,
As we discussed over email, I think Template Haskell would be a good fit for part of this project, namely the API you expose to the underlying Consul functions. Since this API is an extremely thin wrapper, and since several of your API functions used the exact same code to access the Consul client functions, I saw fit to replace the common pieces with TH code that will transform the necessary functions automatically.
I have confirmed that my branch compiles and passes the unit tests you have written.
Please let me know if you'd like me to write some more tests, or change any of my code stylistically.