Skip to content

Conversation

@lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Oct 1, 2025

PR Checklist

  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

Trello card: https://trello.com/c/BxY1aMOZ/2496-update-team-documentation-now-we-no-longer-use-forms-api

The forms-api app is no longer used in any part of our service, its data responsibilities have been moved to the forms-admin app.

This PR updates our documentation and diagrams in this repo to reflect that.

How to review

Describe the steps required to test the changes.

For example:

  1. Semantic: Do you agree with the changes?
  2. Syntactic: Spelling, grammar, etc.

Who can review

Any devs, SREs.

Updated with latest output from rails-erd.
The forms-api app is no longer used in any part of our system, its data
and responsibilities have been moved to the forms-admin app, and this
class diagram is no longer relevant and can be removed.

All of the entity types that were in the forms-api class diagram are now
also in the forms-admin class diagram, so nothing should be lost by
this.
The forms-api app is no longer used in any part of our system, its data
and responsibilities have been moved to the forms-admin app, and
forms-runner retrieves form definitions from forms-admin.

The sequence diagrams in this repo need to be updated to reflect that,
this commit does so.

This does mean that there is less detail in some sequence diagrams,
however this is accurate as to our external API surface; forms-admin
exposes fewer public API endpoints than forms-api did.
@lfdebrux lfdebrux self-assigned this Oct 1, 2025
@lfdebrux lfdebrux requested a review from theseanything October 1, 2025 10:08
@lfdebrux lfdebrux force-pushed the ldeb-remove-forms-api branch from be1751c to a679155 Compare October 1, 2025 10:10
@lfdebrux lfdebrux marked this pull request as ready for review October 1, 2025 10:12
@lfdebrux lfdebrux merged commit 295fea1 into main Oct 1, 2025
@lfdebrux lfdebrux deleted the ldeb-remove-forms-api branch October 1, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants