Skip to content

Conversation

@lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Oct 1, 2025

PR Checklist

  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

We no longer use GOV.UK Notify to send submission emails, instead we use Amazon SES asynchronously. Our documentation and sequence diagrams need to be updated to reflect this, this commit:

  • Add Amazon SES to high level architecture diagram
  • Removes references to GOV.UK Notify from sequence diagram for filling in a form
  • Moves sequence diagrams related to sending submission emails from file upload file to a new file

How to review

Describe the steps required to test the changes.

For example:

  1. Semantic: Do you agree with the changes?
  2. Syntactic: Spelling, grammar, etc.

Who can review

Any devs who worked on SES submissions.

@lfdebrux lfdebrux force-pushed the ldeb-use-ses-for-submission-emails branch from d020cad to a7730eb Compare October 3, 2025 09:47
@lfdebrux lfdebrux self-assigned this Oct 3, 2025
@lfdebrux lfdebrux marked this pull request as ready for review October 3, 2025 09:47
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few updates for things that have changed since the sequence diagram was added

@lfdebrux lfdebrux force-pushed the ldeb-use-ses-for-submission-emails branch from c0fc316 to 2df44ef Compare October 3, 2025 10:46
We no longer use GOV.UK Notify to send submission emails, instead we use
Amazon SES asynchronously. Our documentation and sequence diagrams need
to be updated to reflect this, this commit:

- Add Amazon SES to high level architecture diagram
- Removes references to GOV.UK Notify from sequence diagram for filling
  in a form
- Moves sequence diagrams related to sending submission emails from file
  upload file to a new file
- Updates details around updating submission record with delivery status
  and time

Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
@lfdebrux lfdebrux force-pushed the ldeb-use-ses-for-submission-emails branch from 1d7aa33 to f3b39d4 Compare October 3, 2025 10:47
@lfdebrux
Copy link
Member Author

lfdebrux commented Oct 3, 2025

@stephencdaly thanks for pointing out those changes, I've added them to the commit.

@lfdebrux lfdebrux merged commit 74e86a4 into main Oct 6, 2025
@lfdebrux lfdebrux deleted the ldeb-use-ses-for-submission-emails branch October 6, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants