Support functions get_user_proposals and get_user_esafs now use ORCID instead of LBNLID. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to get ORCID from returned user record if not already supplied. Commenting out warning about missing LBNLID. Support functions get_user_proposals and get_user_esafs now use ORCID instead of LBNLID.
dylanmcreynolds
requested changes
Feb 4, 2026
Contributor
dylanmcreynolds
left a comment
dylanmcreynolds
left a comment
There was a problem hiding this comment.
Request small cleanup changes
alshub/service.py
Outdated
| info('get_user userinfo for orcid: %s lbid: %s', | ||
| id, | ||
| user_lb_id) | ||
| #user_lb_id = user_response_obj.get('LBNLID') |
Contributor
There was a problem hiding this comment.
Please remove commented out code.
Contributor
There was a problem hiding this comment.
Also, I don't think line 75, delcaring user_lb_id is needed anymore
…xception since we got an error.
dylanmcreynolds
approved these changes
Feb 4, 2026
Contributor
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming default of ORCID type, for id supplied to get_user. Attempting to get ORCID from returned user record if not already supplied. Commenting out warning about missing LBNLID.