Skip to content

getBuildProperty: get from default or specific build of first target #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZauberNerd wants to merge 1 commit into from
Closed

getBuildProperty: get from default or specific build of first target #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions lib/pbxProject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,22 +1948,21 @@ pbxProject.prototype.removeFile = function (path, group, opt) {
}



pbxProject.prototype.getBuildProperty = function(prop, build) {
var target;
var configs = this.pbxXCBuildConfigurationSection();
for (var configName in configs) {
if (!COMMENT_KEY.test(configName)) {
var config = configs[configName];
if ( (build && config.name === build) || (build === undefined) ) {
if (config.buildSettings[prop] !== undefined) {
target = config.buildSettings[prop];
}
}
var target = this.getFirstTarget().firstTarget;
var configs = this.pbxXCConfigurationList()[target.buildConfigurationList];
var buildConfigName = build || configs.defaultConfigurationName;

for (var i = 0; i < configs.buildConfigurations.length; i += 1) {
var config = configs.buildConfigurations[i];
var section = this.pbxXCBuildConfigurationSection()[config.value];
if (section.name === buildConfigName) {
return section.buildSettings[prop];
}
}
return target;
}

return undefined;
};

pbxProject.prototype.getBuildConfigByName = function(name) {
var target = {};
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/ReactNativeHelloWorld.json
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 19 additions & 3 deletions test/group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,24 @@ exports.removeResourceFileFromGroup = {
}
}

exports.retrieveBuildPropertyForBuild = {
'should retrieve valid build property ':function(test) {
exports.retrieveBuildProperty = {
'should retrieve build property from default build':function(test) {
var productName = project.getBuildProperty('PRODUCT_NAME');

test.equal(productName, '"HelloCordova"');

test.done();
},
'should retrieve build property from default build of first target':function(test) {
project.hash = require('./fixtures/ReactNativeHelloWorld');

var productName = project.getBuildProperty('PRODUCT_NAME');

test.equal(productName, 'HelloWorld');

test.done();
},
'should retrieve build property from specific build': function(test) {
var releaseTargetedDeviceFamily = project.getBuildProperty('TARGETED_DEVICE_FAMILY', 'Release');
var debugTargetedDeviceFamily = project.getBuildProperty('TARGETED_DEVICE_FAMILY', 'Debug');
var nonExistingProperty = project.getBuildProperty('FOO', 'Debug');
Expand All @@ -257,7 +273,7 @@ exports.retrieveBuildPropertyForBuild = {

test.done();
}
}
};

exports.retrieveBuildConfigByName = {
'should retrieve valid build config':function(test) {
Expand Down