MCAP databags support and use_compressed_images feature #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mcap support with compressed selection feature done
Bugfixes for ffmpeg tool
amansrf
approved these changes
Sep 25, 2023
Owner
amansrf
left a comment
amansrf
left a comment
There was a problem hiding this comment.
Approved, but left some minor suggestions! Thanks for improving this!
| ROSBAG_NAME=$(basename "$d") | ||
| root_dir=$(pwd) | ||
| sleep 2s | ||
| # find "$DATA_DIR" \( -iname "*.db3" -o -iname "*.mcap" \) -print0 | xargs -0 -I file dirname file | while read d; do |
Owner
There was a problem hiding this comment.
Why leave it commented? What you have added right after seems to be an improvement. If this is for backwards compatibility, either version the script or add a flag? Preference is to delete
| for camera_output_dir in "$OUTPUT_DIR"/*/; do | ||
| base_name=$(basename "$camera_output_dir") | ||
| ffmpeg -framerate 50 -pattern_type glob -i '*.jpg' -c:v libx264 -profile:v high -crf 20 -pix_fmt yuv420p ../$base_name.mp4 | ||
|
|
multi_extract.sh
Outdated
| done < /tmp/tempfile.txt | ||
|
|
||
| done | ||
| rm /tmp/tempfile.txt No newline at end of file |
| exit() | ||
|
|
||
| # Iterator dictionary to go over camera messages | ||
| # with Reader(ROSBAG_FILE) as reader: |
Owner
There was a problem hiding this comment.
Delete instead of commenting as much as possible. This is a git repo, can be recovered later if really needed.
…tain image topics. Cleaned up all error messages
Handling edge cases where ROSBAG does not have images, or missing cer…
cleanup, tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool now supports .db3 and .mcap bags seamlessly. Boolean to use compressed images added in multi_extract.sh