-
Notifications
You must be signed in to change notification settings - Fork 36
Reduce ci load by running only on PR or push to master #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Current failure seems to be due to a GitHub outage, will revisit after fix is released |
ecoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending question...
.github/workflows/ats-ci.yml
Outdated
| working-directory: Docker | ||
| run: | | ||
| echo "ATS_BRANCH=$GITHUB_REF_NAME" >> $GITHUB_ENV | ||
| echo "ATS_BRANCH=${{ github.event.pull_request.head.ref }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work if it is not a PR, e.g. if push on master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'm not sure but I would guess not
I'll split this into two jobs that run w/ on different conditions
096bdb4 to
6f270c5
Compare
|
@ecoon updated the logic you had a question about |
No description provided.