-
Notifications
You must be signed in to change notification settings - Fork 124
Add steps to check if there is any source code changed in the incoming pull request. #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tgregg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can we also perform this check before running the ion-test-driver workflow?
Codecov ReportBase: 66.59% // Head: 66.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
=========================================
Coverage 66.59% 66.60%
Complexity 5416 5416
=========================================
Files 156 156
Lines 22751 22751
Branches 4105 4105
=========================================
+ Hits 15152 15153 +1
Misses 6236 6236
+ Partials 1363 1362 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yes, it is doable. It might require some minor change on ion-test-driver workflow too. I'll look into that and make the update. |
| id: check-content | ||
| run: | | ||
| cd ion-java-new | ||
| if [[ $(git log -1 --name-only) == *"src/"* ]]; then echo "result=pass"; else exit 1; fi No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is failing the workflow the only way to achieve the behavior we want? Ideally this job would always succeed, and we'd simply convey the result to the other jobs so to determine if they should run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This not the only way. We can add the steps of PR-content-check to both ion-java-regression-detection.yml and ion-test-driver.yml. Since both of the share the same logic of checking PR content, I'd prefer to reuse the workflow PR-content-check.yml in both applicable workflows to avoid duplication.
|
Updates after commit Update workflows to avoid failing PR-content-check workflow: PR contains source code change: Note: The reason this PR failed the workflows |
tgregg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, this is a big improvement.
…coming pull request. Signed-off-by: Linlin Sun <linls@amazon.com>
Update the trigger events of ion-test-driver and ion-java-performance-regression-detection workflows. Update the output of PR-content-check.




Signed-off-by: Linlin Sun linls@amazon.com
Issue #, if available:
#465
Description of changes:
This PR adds a workflow
PR-content-checkto help us check whether there is any source code changes in the incoming PR. If the changed is detected, the workflow will be completed and executed successfully. WhenPR-content-checkworkflow is completed successfully,ion-test-driverandion-java-regression-detectionworkflows will be triggered. If thePR-content-checkis failed,ion-test-driverandion-java-regression-detectionwill not be executed.This PR also updated the version of
actions/checkoutTest:
srcfolder.ion-test-driverandion-java-regression-detectionwere skipped based on the execution status ofPR-content-checksrcfolder.ion-test-driverandion-java-regression-detectionwere triggered based on the execution status ofPR-content-checkBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.