Add comprehensive type-checking infrastructure #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed all 88 TypeScript errors across the codebase - React Query hooks: Added generic type parameters, replaced deprecated cacheTime with gcTime - Axios client: Fixed type assertions for config objects - Router navigation: Corrected route paths - User types: Added missing username field - Component types: Fixed data access patterns and theme context - AdminGuard: Fixed import path from non-existent authContext to useAuth hook - Added pre-commit type-checking (runs only when TS files are staged) - Created scripts/type-check-if-ts.sh for conditional type-checking - Updated lint-staged config in package.json - Performance: 2-3s for non-TS commits, 8-30s for TS commits - Added GitHub Actions CI workflow - Validates all PRs with type-check, lint, format-check, and tests - Runs on pull requests to main and direct pushes - Updated CLAUDE.md with type safety documentation - Pre-commit hook behavior and performance impact - CI/CD pipeline requirements - How to bypass hooks (not recommended) This ensures type errors are caught before they reach production and provides fast feedback during development. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive TypeScript type-checking infrastructure to prevent type errors from reaching production.
TypeScript Errors Fixed (88 → 0)
cacheTimewithgcTime/notifications/→/notifications, etc.)usernamefieldauthContexttouseAuthhookInfrastructure Added
Pre-commit Type-Checking ✅
scripts/type-check-if-ts.sh- only runs when.ts/.tsxfiles are stagedpackage.jsonlint-staged configGitHub Actions CI Workflow ✅
.github/workflows/ci.yamlnpm run type-check)npm run lint)npm run format:check)npm run test)mainand direct pushesDocumentation ✅
CLAUDE.mdwith type safety sectionTest Plan
npm run type-checkshows 0 errorsBreaking Changes
None - this is purely additive infrastructure.
Migration Notes
Developers will now see type-checking in pre-commit hooks when committing TypeScript files. This adds ~8-30 seconds to TypeScript commits but provides fast feedback before pushing.
To bypass (not recommended):
🤖 Generated with Claude Code