Add RFE creation, update notifications, and reorganize repository #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Features: - Set Inbox as initial screen instead of Sessions - Add 'Create RFE' option to FAB menu with source attachment support - Replace 'Agent' with 'Deep Research' in FAB - Update 'GitHub Notifications' to 'Notifications' with multi-source filtering - Add RFE creation screen with Google Docs, URLs, and Jira source inputs - Add source filtering UI for GitHub, Google Workspace, Jira, GitLab, Miro Repository Organization: - Move dev.sh to scripts/ (new development environment manager) - Move start-offline.sh to scripts/ - Remove obsolete phase implementation scripts - Remove outdated security audit summary - Remove empty implementation log 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The API contract verification document is no longer needed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Removed unused renderQuickAction and quickActionKeyExtractor callbacks that were created for FlatList but not used after refactoring to use direct .map() instead. Fixes ESLint warnings introduced in PR #33. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed pre-existing lint issues in codebase to allow PR to pass CI: Performance & Imports: - app/_layout.tsx: Converted require() to ES6 imports - components/PerformanceMonitor.tsx: Converted require() to ES6 imports, removed unused getMemoryMonitor Unused Variables: - app/admin/*.tsx: Removed unused setPeriod setters (3 files) - app/login.tsx: Removed unused Image import - components/inbox/StuckAgentBanner.tsx: Removed unused router import - app/decisions/[id].tsx: Removed unused error variable - app/sessions/[id]/review.tsx: Removed unused error variables (2 instances) - app/settings/appearance.tsx: Fixed ThemeOption name collision, removed unused Ionicons React Hooks Dependencies: - app/announcements/index.tsx: Wrapped markAsRead in useCallback - app/auth/callback.tsx: Added eslint-disable for intentional one-time effect, removed unused OAUTH_CONFIG - app/settings/index.tsx: Added eslint-disable for intentional one-time effect - components/layout/Header.tsx: Reordered functions to avoid forward reference, added handleSignOut to showUserMenu dependencies All changes are fixes to pre-existing code quality issues, not regressions from PR #33. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implemented all critical and high-impact improvements identified by code-reviewer and code-simplifier agents. **Critical Issues Fixed:** - Implemented source filtering logic in notifications screen - Filters notifications by source (GitHub, Google, Jira, etc.) - Shows empty state for unsupported sources (temporary until multi-source support) - Removed console.log from RFE create screen (production code) - Added input validation for RFE source URLs/IDs - Google Docs URLs validated - URLs validated with protocol check - Jira ticket IDs validated with format check - User-friendly error alerts for invalid inputs **Code Simplifications:** - Replaced getSourceIcon switch statement with SOURCE_ICONS const map - Removed over-memoization in Header component - Moved getInitials to pure function outside component - Removed unnecessary useMemo from firstName and userInitials - Removed useCallback from simple setter functions - Pre-sorted CreateFAB options array to eliminate runtime sorting - Removed additional console.log statements from CreateFAB **Configuration:** - Added .venv/ to .prettierignore to prevent Python venv formatting errors All changes pass TypeScript type-check, ESLint, and Prettier validation. Pre-existing test failures in unrelated components (WorkflowTypeGrid, RepositoryPicker) are not caused by these changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new UI features for RFE (Request for Enhancement) creation and notification management, plus repository cleanup and script organization.
UI Features
RFE Creation Flow:
app/rfe/create.tsx) with:Inbox as Initial Screen:
app/(tabs)/_layout.tsxwithinitialRouteName="inbox"Notifications Enhancement:
FAB Updates:
Repository Organization
Scripts Moved to
scripts/Directory:dev.sh→scripts/dev.sh(new development environment manager)start-offline.sh→scripts/start-offline.shDeleted Obsolete Files:
SECURITY_AUDIT_SUMMARY.md(outdated security audit from Nov 26)API_CONTRACT_VERIFICATION.md(obsolete verification doc)implementation.log(empty log file)implement-phases-auto.sh(obsolete automation script)implement-phases.sh(obsolete workflow script)Kept in Root:
BACKLOG.md(valid development priorities from Nov 26)Files Changed
New:
app/rfe/create.tsx- RFE creation screenscripts/dev.sh- Development environment managerModified:
app/(tabs)/_layout.tsx- Set Inbox as initial screenapp/(tabs)/index.tsx- Updated "GitHub Notifications" to "Notifications"app/notifications/index.tsx- Added multi-source filteringcomponents/layout/CreateFAB.tsx- Added RFE, replaced Agent with Deep ResearchMoved:
start-offline.sh→scripts/start-offline.shDeleted:
SECURITY_AUDIT_SUMMARY.mdAPI_CONTRACT_VERIFICATION.mdimplementation.logimplement-phases-auto.shimplement-phases.shTesting
Development Scripts
The new
scripts/dev.shprovides comprehensive dev environment management:🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com