Skip to content

Features/fix ci#7

Open
justinc1 wants to merge 6 commits intoambitioninc:masterfrom
justinc1:features/fix-ci
Open

Features/fix ci#7
justinc1 wants to merge 6 commits intoambitioninc:masterfrom
justinc1:features/fix-ci

Conversation

@justinc1
Copy link

The current master fails CI tests. The PR fixes this.

I believe also #6 should pass majority of tests if this is accepted. See https://travis-ci.org/github/ambitioninc/rabbitmq-admin/jobs/727879834 - it complains about 8 vs. 9 exchanges, and about 0 vs. 1 connection.

rabbitmq defaults 3.8 changed in last 6 years.
Seems one exchange disapeared.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
It was not compatible with older python versions.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 force-pushed the features/fix-ci branch 2 times, most recently from c8cfd07 to e50f564 Compare April 30, 2021 19:47
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
omoumniabdou pushed a commit to optimdata/rabbitmq-admin that referenced this pull request Oct 22, 2021
* Black
* Fix tests as in ambitioninc#7
* Add env variables for tests
omoumniabdou pushed a commit to optimdata/rabbitmq-admin that referenced this pull request Oct 22, 2021
* Add CRUD on topic-permissions 
* Black
* Fix tests as in ambitioninc#7
* Add env variables for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant