Skip to content

Console Tinting! #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaketendoDev wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Console Tinting! #1759

MaketendoDev wants to merge 6 commits into from

Conversation

@MaketendoDev
Copy link
Member

@MaketendoDev MaketendoDev commented Jul 26, 2025

About the PR

Made the TARDIS console tintable so no need for variants with rotor color changes and also it changes to red if there is an alarm.

Why / Balance

Customization!

Media

https://media.discordapp.net/attachments/1213995158178242631/1398779804370866186/image.png?ex=68869ab5&is=68854935&hm=c64e509d43617e545aebdc001100c7f96964cabe985c4c743584a9c5932bc08a&=&format=webp&quality=lossless&width=1051&height=569

Requirements

Breaking changes

Emissions mayhaps

Changelog

@MaketendoDev
feat: console tinting function!!!!!!!,
444c818 
chore: removed all consoles that just have a different rotor color;
chore: organised the console textures;
@MaketendoDev
fix: deserialising on a console that doesn't exist?
6d600ba
@MaketendoDev
feat: linked console tinting textures
4913acb
@MaketendoDev MaketendoDev requested review from a team as code owners July 26, 2025 22:20
@MaketendoDev MaketendoDev added T: New Feature Type: New feature or content, or extending existing content. S: Help Wanted Status: Requesting additional help for this to be completed. C: Textures Changes: Might require knowledge of spriting or visual design. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the mod. size/L Denotes a PR that changes 1000-4999 lines. S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. D2: Medium Difficulty: A good amount of codebase knowledge required. C: Render Changes: Might require knowledge of shaders and rendering. A: Art Area: Art with no implications for other areas. A: Console Area: Tardis console. labels Jul 26, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Jul 26, 2025
@github-actions
Copy link

github-actions bot commented Jul 26, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@GSMPBot GSMPBot requested review from drtheodor and duzos July 26, 2025 22:20
@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. A: Tardis Components Area: Tardis components & manager. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. labels Jul 26, 2025
@github-actions
Copy link

github-actions bot commented Jul 26, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Jul 26, 2025
@github-actions github-actions bot removed the size/L Denotes a PR that changes 1000-4999 lines. label Jul 27, 2025
@duzos
Copy link
Member

duzos commented Jul 29, 2025

ready?

@MaketendoDev
Copy link
Member Author

MaketendoDev commented Aug 7, 2025

idk why but when you add the colors it doesnt update

@MaketendoDev MaketendoDev removed the S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. label Aug 12, 2025
@MaketendoDev
Copy link
Member Author

MaketendoDev commented Aug 12, 2025

can someone plz fix the merge conflicts just replace them with the new code

@duzos
Copy link
Member

duzos commented Sep 7, 2025

hell hell naw

@MaketendoDev
Copy link
Member Author

MaketendoDev commented Sep 11, 2025

smh i've gone through enough torture making the textures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtheodor drtheodor Awaiting requested review from drtheodor

@duzos duzos Awaiting requested review from duzos

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Art Area: Art with no implications for other areas. A: Console Area: Tardis console. A: Tardis Components Area: Tardis components & manager. C: Render Changes: Might require knowledge of shaders and rendering. C: Textures Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Help Wanted Status: Requesting additional help for this to be completed. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the mod.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaketendoDev @duzos