Feat/astral map biome finder #1929

rapbattlegod32 · 2025-10-12T21:56:17Z

About the PR

astral map has biome locator

Why / Balance

suggestions from discord

Technical details

server config to change the block radius default value is 6400 which seems to work great, too low of a value like 256 will barely get you any results and im afraid too high of a value would be expensive to compute

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

feat: biome finder for the astral map

rapbattlegod32 · 2025-10-12T21:56:40Z

ive tested myself and it works and ive also gotten a beta tester and they had no issues

rapbattlegod32 · 2025-10-12T23:12:05Z

closes #1698

drtheodor

among other things, using ait:loading as a dummy value is rather silly. If it applies to an entire list can't you just make it a separate boolean value like "waitingOnBiomes"..?

src/main/java/dev/amble/ait/client/screens/AstralMapScreen.java

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

rapbattlegod32 · 2025-10-27T05:02:52Z

nitpicks done now approve so nano can do the gui

drtheodor · 2025-10-27T12:39:00Z

src/main/java/dev/amble/ait/client/screens/AstralMapScreen.java

+                this.close();
+            });
+            waitingOnStructures = false;
+            changed = true;


changed is already false

is this supposed to be true?

drtheodor · 2025-10-27T12:40:05Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+    public static List<Identifier> biomeIds;

    static {
        ServerPlayNetworking.registerGlobalReceiver(REQUEST_SEARCH, (server, player, handler, buf, responseSender) -> {


this can include what you're trying to query.

also, this doesn't have a security check. what if the player isnt using an astral map block? hax

this can include what you're trying to query.

this is known in clientside code, and will make the server's job simpler

drtheodor · 2025-10-27T12:43:11Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java


+    private static void sendBiomes(ServerWorld world, ServerPlayerEntity target) {
+        if (biomeIds == null || biomeIds.isEmpty()) {
+            List<Identifier> ids = new ArrayList<>();


this can be a static sized list or an array, iirc the registry's size can be queried

drtheodor · 2025-10-27T12:43:56Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+        }
+
+        PacketByteBuf buf = PacketByteBufs.create();
+        buf.writeInt(biomeIds.size());


there's a writeCollection method already

drtheodor · 2025-10-27T12:44:13Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+                ids.add(buf.readIdentifier());
+            }
+            client.execute(() -> {
+                biomeIds = ids;


add this.

drtheodor · 2025-10-27T12:44:39Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+            }
+            client.execute(() -> {
+                biomeIds = ids;
+                if (client.currentScreen instanceof dev.amble.ait.client.screens.AstralMapScreen screen) {


import the class instead of querying it by its package name

also, i feel like this can be cached client-side (if it isn't already present on client)
im pretty sure client knows of registered biomes... ill check the protocol wiki.

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

drtheodor · 2025-10-27T12:51:21Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+            RegistryKey<Biome> biomekey = RegistryKey.of(RegistryKeys.BIOME, target);
+
+            Pair<BlockPos, RegistryEntry<Biome>> r = targetWorld.locateBiome(
+                    entry -> entry.getKey().map(key -> key.equals(biomekey)).orElse(false),


can be replaced with RegistryEntryPredicateArgumentType.getRegistryEntryPredicate(context, "biome", RegistryKeys.BIOME)

drtheodor · 2025-10-27T12:51:37Z

src/main/java/dev/amble/ait/core/blocks/AstralMapBlock.java

+            RegistryKey<Biome> biomekey = RegistryKey.of(RegistryKeys.BIOME, target);
+
+            Pair<BlockPos, RegistryEntry<Biome>> r = targetWorld.locateBiome(
+                    entry -> entry.getKey().map(key -> key.equals(biomekey)).orElse(false),


can be replaced with RegistryEntryPredicateArgumentType.getRegistryEntryPredicate(context, "biome", RegistryKeys.BIOME)

rapbattlegod32 · 2025-10-27T17:03:36Z

American.Psycho.Dry.Cleaners.If.you.don.t.shut.your.mouth.I.will.kill.you.Ayaa.S4r7og9JTJU.mp4

rapbattlegod32 added 2 commits October 12, 2025 22:01

feat: biome finder on astral map

8546891

feat: server config for the block radius of biome finder

8fe039d

rapbattlegod32 requested a review from a team as a code owner October 12, 2025 21:56

rapbattlegod32 added the S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. label Oct 12, 2025

rapbattlegod32 requested a review from a team as a code owner October 12, 2025 21:56

github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Oct 12, 2025

GSMPBot requested a review from drtheodor October 12, 2025 21:56

github-actions bot added the A: Datagen Area: Datagen implementation & API. label Oct 12, 2025

GSMPBot requested a review from duzos October 12, 2025 21:56

github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Oct 12, 2025

rapbattlegod32 removed the S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. label Oct 12, 2025

drtheodor removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Oct 24, 2025

drtheodor requested changes Oct 24, 2025

View reviewed changes

github-actions bot added S: Awaiting Changes Status: Changes are required before another review can happen. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 24, 2025

rapbattlegod32 added 3 commits October 27, 2025 04:25

chore: remove dead code

9968358

chore: translations

d6ca261

more nitpicks

8d622ea

GSMPBot requested a review from drtheodor October 27, 2025 05:02

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Awaiting Changes Status: Changes are required before another review can happen. labels Oct 27, 2025

drtheodor requested changes Oct 27, 2025

View reviewed changes

github-actions bot added S: Awaiting Changes Status: Changes are required before another review can happen. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 27, 2025

Uh oh!

Feat/astral map biome finder #1929

Are you sure you want to change the base?

Feat/astral map biome finder #1929

Conversation

rapbattlegod32 commented Oct 12, 2025

About the PR

Why / Balance

Technical details

Requirements

Uh oh!

rapbattlegod32 commented Oct 12, 2025

Uh oh!

rapbattlegod32 commented Oct 12, 2025

Uh oh!

drtheodor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rapbattlegod32 commented Oct 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rapbattlegod32 commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants