Open
Conversation
github-actions
bot
added
C: Textures
Member
Author
|
i give up on up and down directions, if someone can give me an example of how i can do it that would be great because ive tried copying what pillar/log blocks do and had no luck |
Member
Author
|
im going to flicker goon for the next 4 hours and then ill try figure this out again |
drtheodor
added
C: UI
drtheodor
requested changes
Dec 26, 2025
| public void appendNarrations(NarrationMessageBuilder builder) { | ||
| WorldEntry selected = this.getSelected(); | ||
| if (selected != null) { | ||
| builder.put(NarrationPart.TITLE, Text.literal("world: ").copy().append(selected.label)); |
| if (selected != null) { | ||
| builder.put(NarrationPart.TITLE, Text.literal("world: ").copy().append(selected.label)); | ||
| } else { | ||
| builder.put(NarrationPart.TITLE, Text.literal("dimension skys")); |
Comment on lines
+24
to
+25
| private static final Identifier DEFAULT_TEXTURE = new Identifier(AITMod.MOD_ID, | ||
| "textures/gui/tardis/monitor/environment_menu_sky.png"); |
Member
There was a problem hiding this comment.
Suggested change
| private static final Identifier DEFAULT_TEXTURE = new Identifier(AITMod.MOD_ID, | |
| "textures/gui/tardis/monitor/environment_menu_sky.png"); | |
| private static final Identifier DEFAULT_TEXTURE = AITMod.id("textures/gui/tardis/monitor/environment_menu_sky.png"); |
Comment on lines
+26
to
+27
| private static final Identifier DIRECTION_TEXTURE = new Identifier(AITMod.MOD_ID, | ||
| "textures/gui/tardis/monitor/environment_menu_direction_compass.png"); |
Member
There was a problem hiding this comment.
Suggested change
| private static final Identifier DIRECTION_TEXTURE = new Identifier(AITMod.MOD_ID, | |
| "textures/gui/tardis/monitor/environment_menu_direction_compass.png"); | |
| private static final Identifier DIRECTION_TEXTURE = AITMod.id("textures/gui/tardis/monitor/environment_menu_direction_compass.png"); |
| int bgWidth = 216; | ||
| int left, top; | ||
|
|
||
| private static final RegistryKey<World> DEFAULT = World.END; |
Member
There was a problem hiding this comment.
this field seems unnecessary?
| } | ||
|
|
||
| private void drawBackground(DrawContext context, GuiSelection current) { | ||
| if (current.equals(GuiSelection.SKY)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (current.equals(GuiSelection.SKY)) { | |
| if (current == GuiSelection.SKY) { |
| return ActionResult.SUCCESS; | ||
| state = state.cycle(ENABLED); | ||
| // world.setBlockState(pos, state, Block.NOTIFY_LISTENERS); | ||
| AITMod.sendProjectorToggle(pos, state.get(ENABLED)); |
Member
There was a problem hiding this comment.
this method should be implemented somewhere else
dont add more stuff to AITMod
| return ActionResult.SUCCESS; | ||
| } | ||
|
|
||
| if (world.isClient){ |
Comment on lines
+100
to
+102
| if (world.isClient){ | ||
| return ActionResult.SUCCESS; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (world.isClient){ | |
| return ActionResult.SUCCESS; | |
| } |
| }); | ||
| }); | ||
|
|
||
| ClientPlayNetworking.registerGlobalReceiver(OPEN_SCREEN_PROJECTOR, (client, handler, buf, responseSender) -> { |
Member
There was a problem hiding this comment.
ideally, all of this should be moved to somewhere more relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
environment projector has gui, made by @lakehascake
Why / Balance
nyx
Technical details
Media
Requirements
Breaking changes
Changelog
🆑