Open
Conversation
amikhalev
requested changes
Nov 7, 2017
| id: number; | ||
|
|
||
| @ManyToMany(type => User) | ||
| @JoinTable({ name: 'students' }) |
Owner
There was a problem hiding this comment.
name is the name of the table joining this to users. You want this to be something like "school_students"
|
|
||
| @ManyToMany(type => User) | ||
| @JoinTable({ name: 'students' }) | ||
| students?: User[]; |
Owner
There was a problem hiding this comment.
This shouldn't be optional, by default it should just be empty
| name: string | null; | ||
|
|
||
| @Column('text', { nullable: true }) | ||
| _validationData: string | null; |
Owner
There was a problem hiding this comment.
https://github.com/typeorm/typeorm/blob/master/docs/entities.md#column-options
Pass a transformer to @column, instead of doing this stuff
| defaultSubject: string | null; | ||
|
|
||
| @Column('int', { length: 4, nullable: true }) | ||
| graduationYear: number | null; |
Owner
There was a problem hiding this comment.
https://github.com/typeorm/typeorm/blob/master/docs/entities.md#column-types-for-mysql--mariadb
This should probably be 'year'
a-bainbridge
force-pushed
the
add-schools
branch
from
aa7b3de to
f1065ca
Compare
Collaborator
Author
|
After this is merged, I'll be using branches off this repo in the future, not forks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's some extra ugly stuff i threw in to try to test this. gonna add better ways to test later