ci: add GitHub Actions CI pipeline with Makefile and golangci-lint#2
Merged
ci: add GitHub Actions CI pipeline with Makefile and golangci-lint#2
Conversation
Run gofmt -w on 6 files with formatting violations to prepare for CI enforcement of consistent formatting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable govet, errcheck, staticcheck, unused, ineffassign, gocritic, and misspell linters. Suppress captLocal check for gopher-lua's conventional L parameter naming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused getBool function in loader/compile.go - Remove unused styledPlayerInput function in tui/style.go - Simplify else-if in loader/loader_test.go (gocritic elseif) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Makefile with build, test, lint, vet, fmt-check, and ci targets. The ci target runs the full pipeline and is used by both local dev and GitHub Actions. Add /bin/ to .gitignore for build output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add CI workflow that calls `make ci` on both PRs and pushes to main. Uses the same Makefile targets developers run locally for full parity. Update PR template with CI checklist item. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the CI/CD implementation plan covering GitHub Actions workflow, Makefile, and golangci-lint configuration choices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
golangci-lint-action v6 does not support golangci-lint v2.x. Upgrade to v7 which adds v2 compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add automated CI/CD pipeline using GitHub Actions with a "local CI" philosophy — the Makefile is the single source of truth for all checks, and GitHub Actions simply calls
make ci..github/workflows/ci.yml) triggered on PRs and pushes to mainbuild,test,lint,vet,fmt-check,fmt,ci, andcleantargetsunusedlinterPurpose
The project had strong engineering practices documented (testing, planning, PRs) but zero automated enforcement. This closes the gap —
make ciruns the same checks locally and in GitHub Actions, ensuring consistent quality gates.Tests Performed
make cipasses locally (fmt-check, vet, lint, build, test — all green)make buildproduces binary atbin/questcoreTests Not Performed
CI Checks
make cipasses locallyAI Assisted
Plan:
docs/plans/ci-setup.md🤖 Generated with Claude Code