Skip to content

Add CSR with EC and ECDSA algo #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saeedkargosha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CSR with EC and ECDSA algo #69

saeedkargosha wants to merge 1 commit into from

Conversation

@saeedkargosha
Copy link
Contributor

@saeedkargosha saeedkargosha commented Dec 8, 2019

No description provided.

@amitaymolko
Copy link
Owner

amitaymolko commented Dec 15, 2019

Thank you for contributing!!!
This is a good start for adding EC support.
Here we have an android implementation but we will also need an iOS implementation.

@saeedkargosha
Copy link
Contributor Author

saeedkargosha commented Dec 15, 2019

Thank you for answering.
I have to add it to iOS for next week
When this is done I will send a pull request

@saeedkargosha
Copy link
Contributor Author

saeedkargosha commented Jan 19, 2020

Hi
I had to rewrite the entire iOS part with swift
Can I send a pull request?

@amitaymolko
Copy link
Owner

amitaymolko commented Jan 20, 2020

Sure, but why rewrite to swift?

@saeedkargosha
Copy link
Contributor Author

saeedkargosha commented Jan 20, 2020

because of generating CSR

@amitaymolko amitaymolko mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saeedkargosha @amitaymolko