Work to refactor amuse.rfi #1078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/amuse/rfi/async_request.py # src/amuse/rfi/channel.py # src/amuse/rfi/gencode.py # src/amuse/rfi/python_code.py
LourensVeen
reviewed
Oct 30, 2024
Member
LourensVeen
left a comment
LourensVeen
left a comment
There was a problem hiding this comment.
Looks good overall but I've left some questions and a proposal for one more fix.
| result = self.read_fortran_block_floats(file) | ||
| return result.reshape(len(result) // size, size) | ||
|
|
||
| def write_fortran_block(self, file, input): |
Member
There was a problem hiding this comment.
What does this code do? Is there anything affected by this?
| @@ -1,236 +1,297 @@ | |||
| import numpy | |||
| import os.path | |||
| from amuse.community import * | |||
Member
There was a problem hiding this comment.
This is not a syntax update to amuse.rfi. Was that intended?
|
|
||
| from amuse.rfi import slurm | ||
|
|
||
| from . import async_request |
Member
There was a problem hiding this comment.
This file is such a disaster. But at least it's now a nicely formatted disaster. Great!
|
|
||
|
|
||
| def cleanup_module(mod): | ||
| #print "CLEANUP!!" |
Member
There was a problem hiding this comment.
Maybe this Python 2 comment could just go?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status: stale
LourensVeen
added
status: keep-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.