Skip to content

Conversation

@ErwanH29
Copy link
Collaborator

@ErwanH29 ErwanH29 commented Nov 3, 2025

In amuse/src/amuse/ext/protodisk.py variables were still mapped to outdated names.
Also modified error messages and removed unused libraries from the import line.

@ErwanH29 ErwanH29 requested a review from a team as a code owner November 3, 2025 15:26
@rieder
Copy link
Member

rieder commented Nov 3, 2025

Currently you have entirely removed the error messages, was that intentional? I'd like to keep them while both old and new style keywords are accepted.

@ErwanH29
Copy link
Collaborator Author

ErwanH29 commented Nov 3, 2025

Keeping them is fine if that is preferred. I am not familiar with the standard.
I only changed it because when I first encountered the bug, I didn’t fully understand the error until I looked into the source code. The new variables have default values, so prompting the function with old variable names will automatically invoke the various ValueError messages.
It seemed easier to remove the error message, warn the user of the deprecated variables, and just directly map the old variables to the new ones. That, or removing the old variable names completely.

@HannoSpreeuw HannoSpreeuw moved this from Backlog to Open PRs in Development Board Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Open PRs

Development

Successfully merging this pull request may close these issues.

2 participants