Fix range sendFile() for MinGW #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luk1337
force-pushed
the
luk/sendfile_mingw
branch
from
126d23d to
06e247c
Compare
Contributor
Author
|
rebased just so CI is green, no other changes have been made. |
luk1337
force-pushed
the
luk/sendfile_mingw
branch
from
06e247c to
3a6f32c
Compare
Contributor
Author
tho it seems like github is 503-ing at random when downloading gtest so too bad, no green CI for me. |
Since toNativePath() returns std::string for MinGW win32, we end up in an infinite loop.
luk1337
force-pushed
the
luk/sendfile_mingw
branch
from
3a6f32c to
bd56aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since toNativePath() returns std::string for MinGW win32, we end up in an infinite loop.