Skip to content

Fix fread check for reading randomness #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marty1885 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix fread check for reading randomness #384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff93b2b
Fix fread check for reading randomness
marty1885 Dec 11, 2025
a1e0c31
Fix fread condition to check for equality
marty1885 Dec 11, 2025
2d5dec9
Use microseconds
marty1885 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions trantor/utils/Utilities.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ static bool systemRandomBytes(void *ptr, size_t size)
LOG_FATAL << "Failed to open /dev/urandom for randomness";
abort();
}
if (fread(ptr, 1, size, fptr.get()) != 0)
if (fread(ptr, 1, size, fptr.get()) == size)
return true;
#endif
return false;
Expand Down Expand Up @@ -533,9 +533,9 @@ bool secureRandomBytes(void *data, size_t len)
auto now = chrono::steady_clock::now();
// the proposed algorithm uses the time in nanoseconds, but we don't have a
// way to read it (yet) not C++ provided a standard way to do it. Falling
// back to milliseconds. This along with additional entropy is hopefully
// back to microseconds. This along with additional entropy is hopefully
// good enough.
state.time = chrono::time_point_cast<chrono::milliseconds>(now)
state.time = chrono::time_point_cast<chrono::microseconds>(now)
.time_since_epoch()
.count();
// `now` lives on the stack, so address in each call _may_ be different.
Expand Down