Corundum 10 Gbps QSFP+ support for ADRV9009ZU11EG #1971

cristianmihaipopa · 2025-12-05T16:12:14Z

PR Description

Added support for Corundum Network Stack on ADRV9009ZU11EG. This feature is only available for ADRV9009ZU11EG/ADRV2CRR-FMC variant of the project. Currently, this Corundum configuration supports 10 Gbps on QSFP+ connection. In this PR, the main changes are:

In library/corundum added the ethernet core and configuration files for support on ADRV9009ZU11EG
In projects/adrv9009zu11eg/adrv2crr_fmc added all the files specific to the Corundum stack
Updated the documentation to reflect the changes as well (README + project documentation page)

In order to build the project and have the Corundum stack integrated, the user needs to use the new parameter called CORUNDUM and set it to 1 (default it's 0).

IMPORTANT: The Corundum stack was integrated according to our already present Corundum infrastructure and it's very similar to the other projects which support Corundum, besides one thing. In this project, the Corundum Reset Generator, it's not used, it's bypassed, the Corundum hierarchy is directly connected to the PS clock (of 250 MHz) and directly connected to the PS aresetn.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)
Documentation

PR Checklist

I have followed the code style guidelines
I have performed a self-review of changes
I have compiled all hdl projects and libraries affected by this PR
I have tested in hardware affected projects, at least on relevant boards
I have commented my code, at least hard-to-understand parts
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
I have not introduced new Warnings/Critical Warnings on compilation
I have added new hdl testbenches or updated existing ones

library/corundum/scripts/corundum.tcl

library/corundum/scripts/corundum_adrv9009zu11eg_cfg.tcl

projects/adrv9009zu11eg/adrv2crr_fmc/system_bd_corundum.tcl

projects/adrv9009zu11eg/adrv2crr_fmc/system_constr_corundum.xdc

projects/adrv9009zu11eg/common/adrv9009zu11eg_bd.tcl

docs/projects/adrv9009zu11eg/index.rst

IstvanZsSzekely

Please rebase the PR on the current main branch and solve the conflicts.

cristianmihaipopa · 2025-12-09T15:03:20Z

V1: Did the requested changes. The Guideline checker is failing because of the Copyright in /library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg.v, but it's similar to the other .v files from /library/corundum/ethernet.

docs/projects/adrv9009zu11eg/index.rst

IstvanZsSzekely · 2025-12-09T16:28:27Z

docs/projects/adrv9009zu11eg/index.rst

+be cloned alongside HDL repository. Do a git checkout to the latest tested
+version (commit - 37f2607). When the 10G-based implementation (e.g., in
+this project) is used, apply the indicated patch. Then navigate back to the
+location of the project, and build the project using the enviromental variable


Typo: environment variable.

docs/projects/adrv9009zu11eg/index.rst

library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg_ip.tcl

projects/adrv9009zu11eg/adrv2crr_fmc/README.md

projects/adrv9009zu11eg/adrv2crr_fmc/system_bd.tcl

projects/adrv9009zu11eg/adrv2crr_fmc/system_bd_corundum.tcl

projects/adrv9009zu11eg/common/adrv9009zu11eg_bd.tcl

cristianmihaipopa · 2025-12-12T12:32:00Z

V2: Did the requested changes.

library/corundum/scripts/corundum.tcl

PopPaul2021

Looks good to me!

library/corundum/scripts/corundum.tcl

cristianmihaipopa · 2025-12-18T15:05:45Z

V3: In corundum.tcl we have a common if for ptp signals for K26 and ADRV9009ZU11EG.

PopPaul2021

Looks good to me!

docs/projects/adrv9009zu11eg/index.rst

IstvanZsSzekely · 2025-12-19T09:38:21Z

docs/projects/adrv9009zu11eg/index.rst

+be cloned alongside HDL repository. Do a git checkout to the latest tested
+version (commit - 37f2607). When the 10G-based implementation (e.g., in
+this project) is used, apply the indicated patch. Then navigate back to the
+location of the project, and build the project using the enviromental variable


library/corundum/scripts/corundum.tcl

projects/adrv9009zu11eg/adrv2crr_fmc/system_bd_corundum.tcl

projects/adrv9009zu11eg/common/adrv9009zu11eg_bd.tcl

library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg_ip.tcl

- Initial Corundum support, use mode is QSFP+ 10Gbps variant, for ADRV9009ZU11EG - Added the configuration, scripts and ethernet architecure for support on ADRV9009ZU11EG - In corundum.tcl, changed the last if case to be more explicit, for MicroBlaze case Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>

- Corundum support is ONLY available for the ADRV9009ZU11EG/ADRV2CRR_FMC variant of the project - Created a new constraints file, alongside with a new top file, for routing the QSFP signals - Added a separate bd.tcl script, to handle the necessary exports, configurations and connections for Corundum features - Added a new build mode for Corundum, by using the new parameter called CORUNDUM (make CORUNDUM=1) - All the Corundum dependecies are contraint by this variable; if the variable it's not specied when using make, the default variant of the project will be built - IMPORTANT: this implementaion of the Corundum IP, bypasses the Corundum Reset Generator (as seen in the other implementations), connects the Corundum Hierarchy reset and clock directly to the PS Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>

- Updated the projects/adrv9009zu11eg/adrv2crr_fmc/README.md - Updated ADRV9009ZU11EG documentation Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>

IstvanZsSzekely · 2025-12-19T13:28:21Z

projects/adrv9009zu11eg/adrv2crr_fmc/system_top_corundum.v

+              0'b0,         // 11
+              0'b0,         // 10
+              0'b0,         // 9
+              0'b0,         // 8


Vivado critical warnings: multi-driven nets and illegal expression in output port connections.
These signals are inout ports, which mean that they can be both input and output. Having these values hardcoded to any value means that when in input mode, the input signal is driven by the output value of the FPGA and the hardcoded value, thus resulting in multi-driven net.
Please remove these GPIO pins from the IOB instantiation.

IstvanZsSzekely · 2025-12-19T13:31:55Z

projects/adrv9009zu11eg/adrv2crr_fmc/system_top_corundum.v

+    .gpio_i (gpio_i),
+    .gpio_o (gpio_o),
+    .gpio_t (gpio_t),


Port width mismatch between system_top and system_wrapper.

IstvanZsSzekely · 2025-12-19T13:41:10Z

projects/adrv9009zu11eg/adrv2crr_fmc/system_bd_corundum.tcl

+ad_connect smartconnect_corundum/ARESETN sys_ps8/pl_resetn1
+ad_connect smartconnect_corundum/S00_ARESETN sys_ps8/pl_resetn1
+ad_connect smartconnect_corundum/M00_ARESETN sys_ps8/pl_resetn1
+ad_connect smartconnect_corundum/M01_ARESETN sys_ps8/pl_resetn1


Vivado critical warning: reset pin is asynchronous to the input clock.
Please synchronize the reset to the clock source.

IstvanZsSzekely · 2025-12-19T14:04:08Z

projects/adrv9009zu11eg/adrv2crr_fmc/system_top_corundum.v

+  /*
+  * Ethernet: QSFP28
+  */
+  output wire         qsfp_resetl,
+  input  wire         qsfp_modprsl,
+  input  wire         qsfp_intl,
+  output wire         qsfp_lpmode,


qsfp_modsell is not connected in the top module. Is this intentional?

IstvanZsSzekely · 2025-12-19T14:07:35Z

library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg.v

+  assign  qsfp_drp_rst = rst_125mhz_int;
+
+  wire qsfp_rx_block_lock;
+  wire qsfp_gtpowergood;


qsfp_gtpowergood is already declared in the input port list.

IstvanZsSzekely · 2025-12-19T14:08:35Z

library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg.v

+  wire qsfp_modprsl_int;
+  wire qsfp_intl_int;


These signals are used before they are declared.

IstvanZsSzekely · 2025-12-19T14:09:19Z

library/corundum/ethernet/adrv9009zu11eg/ethernet_adrv9009zu11eg.v

+  reg qsfp_reset_reg = 1'b0;
+  reg qsfp_lpmode_reg = 1'b0;


These signals are used before they are declared.

cristianmihaipopa requested review from IstvanZsSzekely and PopPaul2021 December 5, 2025 16:12

cristianmihaipopa requested review from AndrDragomir, IuliaCMoldovan, LBFFilho, StancaPop, alin724, bluncan and gastmaier as code owners December 5, 2025 16:12

cristianmihaipopa changed the title ~~Corundum support for ADRV9009ZU11EG~~ Corundum 10 Gbps QSFP+ support for ADRV9009ZU11EG Dec 5, 2025

PopPaul2021 requested changes Dec 8, 2025

View reviewed changes

IstvanZsSzekely requested changes Dec 8, 2025

View reviewed changes

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch 3 times, most recently from d622b03 to 066733e Compare December 9, 2025 14:48

cristianmihaipopa requested review from IstvanZsSzekely and PopPaul2021 December 9, 2025 15:03

IstvanZsSzekely requested changes Dec 9, 2025

View reviewed changes

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch 2 times, most recently from 7c00bdb to d11d2f1 Compare December 12, 2025 12:31

cristianmihaipopa requested a review from IstvanZsSzekely December 12, 2025 12:32

cristianmihaipopa mentioned this pull request Dec 15, 2025

Added Corundum support for ADRV9009ZU11EG analogdevicesinc/linux#3049

Open

8 tasks

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch from d11d2f1 to 8411aa1 Compare December 15, 2025 13:26

PopPaul2021 requested changes Dec 16, 2025

View reviewed changes

library/corundum/scripts/corundum.tcl Outdated Show resolved Hide resolved

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch from 8411aa1 to bd0b0cd Compare December 16, 2025 12:18

PopPaul2021 self-requested a review December 16, 2025 13:57

PopPaul2021 previously approved these changes Dec 16, 2025

View reviewed changes

alin724 reviewed Dec 16, 2025

View reviewed changes

library/corundum/scripts/corundum.tcl Outdated Show resolved Hide resolved

cristianmihaipopa dismissed PopPaul2021’s stale review via 4469f44 December 18, 2025 15:03

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch from bd0b0cd to 4469f44 Compare December 18, 2025 15:03

cristianmihaipopa requested review from PopPaul2021 and alin724 December 18, 2025 15:04

alin724 previously approved these changes Dec 19, 2025

View reviewed changes

PopPaul2021 previously approved these changes Dec 19, 2025

View reviewed changes

IstvanZsSzekely requested changes Dec 19, 2025

View reviewed changes

cristianmihaipopa added 3 commits December 19, 2025 14:55

Updated documentation regarding Corundum addition to ADRV9009ZU11EG

2837b7c

- Updated the projects/adrv9009zu11eg/adrv2crr_fmc/README.md - Updated ADRV9009ZU11EG documentation Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>

cristianmihaipopa dismissed stale reviews from PopPaul2021 and alin724 via 2837b7c December 19, 2025 13:13

cristianmihaipopa force-pushed the adrv9009zu11eg_qsfp_10_pr branch from 4469f44 to 2837b7c Compare December 19, 2025 13:13

cristianmihaipopa requested a review from IstvanZsSzekely December 19, 2025 13:57

IstvanZsSzekely requested changes Dec 19, 2025

View reviewed changes

Corundum 10 Gbps QSFP+ support for ADRV9009ZU11EG #1971

Are you sure you want to change the base?

Corundum 10 Gbps QSFP+ support for ADRV9009ZU11EG #1971

Uh oh!

Conversation

cristianmihaipopa commented Dec 5, 2025

PR Description

PR Type

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IstvanZsSzekely left a comment

Choose a reason for hiding this comment

Uh oh!

cristianmihaipopa commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cristianmihaipopa commented Dec 12, 2025

Uh oh!

Uh oh!

PopPaul2021 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cristianmihaipopa commented Dec 18, 2025

Uh oh!

PopPaul2021 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants