Skip to content

Conversation

@ozan956
Copy link

@ozan956 ozan956 commented Dec 10, 2025

PR Description

Patch for ADSP SC5xxx boards to have proper GPIO expander names.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@ozan956 ozan956 requested a review from pamolloy December 10, 2025 11:08
@ozan956 ozan956 self-assigned this Dec 10, 2025
@pamolloy pamolloy requested a review from nunojsa December 11, 2025 11:01
@gastmaier
Copy link
Contributor

would be nice if

ld: drivers/soc/adi/system.o: in function `system_config_probe':
system.c:(.text+0x416): undefined reference to `__devm_regmap_init_mmio_clk'

I believe it depends on it but doesn't depends on the kconfig

@pamolloy
Copy link
Collaborator

pamolloy commented Dec 11, 2025

would be nice if

ld: drivers/soc/adi/system.o: in function `system_config_probe':
system.c:(.text+0x416): undefined reference to `__devm_regmap_init_mmio_clk'

I believe it depends on it but doesn't depends on the kconfig

I'll try to deal with it in a new PR, but the issue is that the code is not conditionalized. There is no drivers/soc/adi/Kconfig and the Makefile just obj-y += system.o. As I recall this was something that mainline didn't like. Need to dig into how Arturs dealt with it in his series, but even if it does fix it that has been applied to adsp-6.12.38-y.

Copy link
Collaborator

@pamolloy pamolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an updated description and replacing gpio_handler

@ozan956 ozan956 force-pushed the rename-gpio-expander branch 2 times, most recently from 15ef6b7 to 82d41f6 Compare December 22, 2025 11:34
Rename GPIO expander labels across ADI SC57x/SC59x device trees
to descriptive identifiers.

Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
@ozan956 ozan956 force-pushed the rename-gpio-expander branch from 82d41f6 to c089cd7 Compare December 22, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants