-
-
Notifications
You must be signed in to change notification settings - Fork 191
feat(ical): add icalendar package #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
66eeda3 to
da3ede7
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 11 files
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| // Re-export all functions and types | ||
| export * from "./import"; | ||
| export * from "./export"; | ||
| export type { iCalendarEvent } from "./interfaces"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment claims all types are re-exported, but iCalendar interface isn’t exposed via the public entrypoint; re-export it for API completeness.
Prompt for AI agents
Address the following comment on packages/ical/src/index.ts at line 4:
<comment>Comment claims all types are re-exported, but iCalendar interface isn’t exposed via the public entrypoint; re-export it for API completeness.</comment>
<file context>
@@ -0,0 +1,4 @@
+// Re-export all functions and types
+export * from "./import";
+export * from "./export";
+export type { iCalendarEvent } from "./interfaces";
</file context>
| "@repo/typescript-config": "workspace:*", | ||
| "@types/node": "^22.9.0", | ||
| "eslint": "^9.30.1", | ||
| "typescript": "^5.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript version here diverges from the monorepo (^5.9.2 elsewhere), which can cause inconsistent type checking; align to the shared version.
Prompt for AI agents
Address the following comment on bun.lock at line 263:
<comment>TypeScript version here diverges from the monorepo (^5.9.2 elsewhere), which can cause inconsistent type checking; align to the shared version.</comment>
<file context>
@@ -248,6 +249,23 @@
+ "@repo/typescript-config": "workspace:*",
+ "@types/node": "^22.9.0",
+ "eslint": "^9.30.1",
+ "typescript": "^5.8.3",
+ },
+ "peerDependencies": {
</file context>
| "@repo/eslint-config": "workspace:*", | ||
| "@repo/typescript-config": "workspace:*", | ||
| "@types/node": "^22.9.0", | ||
| "eslint": "^9.30.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint version here diverges from the monorepo (^9.34.0 elsewhere), leading to inconsistent linting; align to the shared version.
Prompt for AI agents
Address the following comment on bun.lock at line 262:
<comment>ESLint version here diverges from the monorepo (^9.34.0 elsewhere), leading to inconsistent linting; align to the shared version.</comment>
<file context>
@@ -248,6 +249,23 @@
+ "@repo/eslint-config": "workspace:*",
+ "@repo/typescript-config": "workspace:*",
+ "@types/node": "^22.9.0",
+ "eslint": "^9.30.1",
+ "typescript": "^5.8.3",
+ },
</file context>
Summary
Testing
bun run formatbun run linthttps://chatgpt.com/codex/tasks/task_e_68765fec40f4832b80bd06916feac8de