feat: Validate event date range #406

JeanMeijer · 2025-10-31T19:20:37Z

Description

Adds validation to the Events API to ensure the event's start date is before its end date using a Zod schema and Temporal.Instant.compare().

Screenshots / Recordings

Type of Change

Related Areas

Authentication
Calendar UI
Data/API
Docs

Testing

Manual testing performed
Cross-browser testing (if UI changes)
Mobile responsiveness verified (if UI changes)

Checklist

I’ve read the CONTRIBUTING guide
My code works and is understandable and follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in complex areas
I have updated the documentation
Any dependent changes are merged and published

Notes

Want me to make any changes? Add a review or comment with @tembo and i'll get back to work!

Summary by cubic

Validate event date ranges in the Events API to ensure start is before end. This blocks invalid events across create and update.

New Features
- Use isBefore with an isSameType guard from @repo/temporal to only compare matching Temporal types.
- Added Zod refine to createEventInputSchema with a clear error on start.
- Switched updateEventInputSchema to safeExtend to keep the validation on updates.

^{Written for commit b4d71dd. Summary will update automatically on new commits.}

Co-authored-by: Jean <jean@analoginterface.io>

vercel · 2025-10-31T19:20:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
analog	Ready	Preview	Comment	Nov 5, 2025 11:12am

coderabbitai · 2025-10-31T19:20:46Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

JeanMeijer · 2025-10-31T19:22:47Z

@tembo use isBefore from @repo/temporal instead

tembo · 2025-10-31T19:24:23Z

@tembo use isBefore from @repo/temporal instead

Updated to use isBefore from @repo/temporal as requested. Replaced the custom isStartBeforeEnd helper function with the standardized utility.

cubic-dev-ai

1 issue found across 1 file

Prompt for AI agents (all 1 issues)


Understand the root cause of the following 1 issues and fix them.


<file name="packages/schemas/src/events.ts">

<violation number="1" location="packages/schemas/src/events.ts:236">
Calling `isBefore(data.start, data.end)` without options will throw for mixed Temporal types/time zones allowed by `dateInputSchema`, causing validation to blow up instead of returning a proper error. Please guard these cases or provide the required compare options before calling `isBefore`.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-10-31T19:35:54Z

packages/schemas/src/events.ts

+    createdAt: z.instanceof(Temporal.Instant).optional(),
+    updatedAt: z.instanceof(Temporal.Instant).optional(),
+  })
+  .refine((data) => isBefore(data.start, data.end), {


Calling isBefore(data.start, data.end) without options will throw for mixed Temporal types/time zones allowed by dateInputSchema, causing validation to blow up instead of returning a proper error. Please guard these cases or provide the required compare options before calling isBefore.

Prompt for AI agents

Address the following comment on packages/schemas/src/events.ts at line 236: <comment>Calling `isBefore(data.start, data.end)` without options will throw for mixed Temporal types/time zones allowed by `dateInputSchema`, causing validation to blow up instead of returning a proper error. Please guard these cases or provide the required compare options before calling `isBefore`.</comment> <file context> @@ -205,33 +207,38 @@ export const recurrenceSchema = z + createdAt: z.instanceof(Temporal.Instant).optional(), + updatedAt: z.instanceof(Temporal.Instant).optional(), + }) + .refine((data) => isBefore(data.start, data.end), { + message: "Event start time must be earlier than end time", + path: ["start"], </file context>

✅ Addressed in b4d71dd

JeanMeijer · 2025-10-31T19:39:34Z

@tembo add a function to the temporal package to check whether two temporal objects are the same type plaindate, zoneddatetime, or instant. performed a check first in refine don't add any comments and choose the same style as we for example with it before function.

…lidation

tembo · 2025-10-31T19:41:03Z

@tembo add a function to the temporal package to check whether two temporal objects are the same type plaindate, zoneddatetime, or instant. performed a check first in refine don't add any comments and choose the same style as we for example with it before function.

Added isSameType utility function to the temporal package to check if two temporal objects share the same type. Updated the refine check to skip validation when start and end are different types, preventing comparison errors between mixed temporal types like PlainDate and ZonedDateTime.

cubic-dev-ai

Reviewed changes from recent commits (found 1 issue).

1 issue found across 2 files

Prompt for AI agents (all 1 issues)


Understand the root cause of the following 1 issues and fix them.


<file name="packages/schemas/src/events.ts">

<violation number="1" location="packages/schemas/src/events.ts:236">
The new refine short-circuits for mixed Temporal types, so events where the end precedes the start (e.g., PlainDate start vs Instant end) now pass validation. Please keep the comparison and fail when types differ instead of bypassing the check.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-10-31T19:51:25Z

packages/schemas/src/events.ts

+    createdAt: z.instanceof(Temporal.Instant).optional(),
+    updatedAt: z.instanceof(Temporal.Instant).optional(),
+  })
+  .refine((data) => !isSameType(data.start, data.end) || isBefore(data.start, data.end), {


The new refine short-circuits for mixed Temporal types, so events where the end precedes the start (e.g., PlainDate start vs Instant end) now pass validation. Please keep the comparison and fail when types differ instead of bypassing the check.

Prompt for AI agents

Address the following comment on packages/schemas/src/events.ts at line 236: <comment>The new refine short-circuits for mixed Temporal types, so events where the end precedes the start (e.g., PlainDate start vs Instant end) now pass validation. Please keep the comparison and fail when types differ instead of bypassing the check.</comment> <file context> @@ -233,7 +233,7 @@ export const createEventInputSchema = z updatedAt: z.instanceof(Temporal.Instant).optional(), }) - .refine((data) => isBefore(data.start, data.end), { + .refine((data) => !isSameType(data.start, data.end) || isBefore(data.start, data.end), { message: "Event start time must be earlier than end time", path: ["start"], </file context>

Suggested change

.refine((data) => !isSameType(data.start, data.end) || isBefore(data.start, data.end), {

.refine((data) => isSameType(data.start, data.end) && isBefore(data.start, data.end), {

✅ Addressed in b4d71dd

JeanMeijer · 2025-11-05T11:07:05Z

@tembo resolve the merge conflict, fix the type errors, and run format

tembo · 2025-11-05T11:10:19Z

@tembo resolve the merge conflict, fix the type errors, and run format

Resolved the merge conflict, fixed type errors by adding explicit type guards for each Temporal type (PlainDate, Instant, ZonedDateTime) before calling isBefore, and ran formatter to clean up imports and formatting.

cubic-dev-ai

No issues found across 1 file

feat(events): Add date range validation to event schema

02e10d3

Co-authored-by: Jean <jean@analoginterface.io>

vercel bot deployed to Preview October 31, 2025 19:23 View deployment

refactor(events): use isBefore from @repo/temporal for validation

9f0c79f

vercel bot had a problem deploying to Preview October 31, 2025 19:25 Failure

cubic-dev-ai bot reviewed Oct 31, 2025

View reviewed changes

refactor(schemas): add type guard for temporal comparison in event va…

ff5dc52

…lidation

vercel bot had a problem deploying to Preview October 31, 2025 19:42 Failure

cubic-dev-ai bot reviewed Oct 31, 2025

View reviewed changes

fix(schemas): add type guards and format validation refine

b4d71dd

vercel bot deployed to Preview November 5, 2025 11:12 View deployment

cubic-dev-ai bot reviewed Nov 5, 2025

View reviewed changes

	.refine((data) => !isSameType(data.start, data.end) \|\| isBefore(data.start, data.end), {
	.refine((data) => isSameType(data.start, data.end) && isBefore(data.start, data.end), {

Uh oh!

feat: Validate event date range #406

Are you sure you want to change the base?

feat: Validate event date range #406

Uh oh!

Conversation

JeanMeijer commented Oct 31, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots / Recordings

Type of Change

Related Areas

Testing

Checklist

Notes

Summary by cubic

Uh oh!

vercel bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

JeanMeijer commented Oct 31, 2025

Uh oh!

tembo bot commented Oct 31, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeanMeijer commented Oct 31, 2025

Uh oh!

tembo bot commented Oct 31, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeanMeijer commented Nov 5, 2025

Uh oh!

tembo bot commented Nov 5, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JeanMeijer commented Oct 31, 2025 •

edited by cubic-dev-ai bot

Loading

vercel bot commented Oct 31, 2025 •

edited

Loading

coderabbitai bot commented Oct 31, 2025 •

edited

Loading

cubic-dev-ai bot Oct 31, 2025 •

edited

Loading

cubic-dev-ai bot Oct 31, 2025 •

edited

Loading