Skip to content

Conversation

@ccmdi
Copy link
Contributor

@ccmdi ccmdi commented Nov 2, 2025

Description

Prevent drag from starting when pointer is outside event bounds by checking the cursor pos against event bounds. I think this is better UX (prevents the current situation where you can drag your cursor with the event despite it being very far away), but let me know if this has different plans to be fixed.

Screenshots / Recordings

Add screenshots or recordings here to help reviewers understand your changes.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • UI/UX update
  • Docs update
  • Refactor / Cleanup

Related Areas

  • Authentication
  • Calendar UI
  • Data/API
  • Docs

Testing

  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Checklist

  • I’ve read the CONTRIBUTING guide
  • My code works and is understandable and follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • Any dependent changes are merged and published

Notes

(Optional) Add anything else you'd like to share.

By submitting, I confirm I understand and stand behind this code. If AI was used, I’ve reviewed and verified everything myself.


Summary by cubic

Stop event drag from starting when the pointer is outside the event, preventing ghost drags and improving accuracy in the calendar. Adds a simple hit-test on the event element before the drag begins.

  • Bug Fixes
    • Hit-test pointer against event bounds in onDragStart; abort if out of bounds.
    • Early return in onDragEnd when drag never started.
    • Added elementRef to event containers to read bounding rects.

Written for commit 66b9025. Summary will update automatically on new commits.

@vercel
Copy link

vercel bot commented Nov 2, 2025

@ccmdi is attempting to deploy a commit to the analogdotnow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Nov 2, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@JeanMeijer JeanMeijer self-requested a review November 5, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants