This repository was archived by the owner on Oct 12, 2023. It is now read-only.
Some refactoring #18
Open
Some refactoring #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Those are BC breaking changes. I'd rather have them in 1.0. |
Contributor
Author
|
Yes, though according to semantic versioning BC breaking changes are fine for minor updates as long as the major version is 0 and users having ^0.2 in their composer.json won't get version 0.3. The currently documented usage is still possible, so I see no problem introducing the changes before 1.0. |
Owner
|
Yes i suppose you are right. We can slowly prepare a 0.4 in the master branch. |
Contributor
Author
|
Shall I change the target branch of this PR to master? |
Owner
|
Yes please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done some refactoring. WDYT?