Upgrade to dune and Opam 2 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selasiehanson
changed the title
Author
|
@andreas, I'm not sure if had a chance to look at this. |
Owner
|
Sorry for the late reply — for some reason I didn’t get an email notification about the PR. I’ll take a look this week. |
andreas
reviewed
Nov 7, 2019
Owner
andreas
left a comment
andreas
left a comment
There was a problem hiding this comment.
Thanks for doing this! I added a few comments.
dataloader-lwt/test/dune
Outdated
| (deps | ||
| (:< test.exe)) | ||
| (action | ||
| (run %{<} -v))) |
Owner
There was a problem hiding this comment.
I think this file can be define more concisely like so:
(test
(libraries dataloader-lwt lwt.unix alcotest)
(name test))
dataloader/test/dune
Outdated
| (deps | ||
| (:< test.exe)) | ||
| (action | ||
| (run %{<} -v))) |
Owner
There was a problem hiding this comment.
This file can be shortened like the other one 😄
dataloader.opam
Outdated
| "jbuilder" {build} | ||
| "ocaml" {>= "4.03.0"} | ||
| "dune" {build & >= "1.0"} | ||
| "rresult" |
Owner
There was a problem hiding this comment.
It turns out rresult is not used, so would be great to remove.
dataloader/src/dune
Outdated
| (name dataloader) | ||
| (public_name dataloader) | ||
| (wrapped false) | ||
| (libraries result)) |
annotate alcotest with `{with-test}` variable
Co-Authored-By: Andreas Garnaes <andreas@users.noreply.github.com>
test annotation for alcotest Co-Authored-By: Andreas Garnaes <andreas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.