feat: add hello API with GET and POST endpoints and tests#16
Merged
andy89923 merged 3 commits intoandy89923:stu/113from Jan 2, 2025
Merged
feat: add hello API with GET and POST endpoints and tests#16andy89923 merged 3 commits intoandy89923:stu/113from
andy89923 merged 3 commits intoandy89923:stu/113from
Conversation
Owner
|
@williamlin0518 Please fix the linter errors. |
williamlin0518
force-pushed
the
feature/hello
branch
from
d781d1d to
a24543a
Compare
andy89923
requested changes
Jan 1, 2025
internal/sbi/api_chiikawa_test.go
Outdated
| @@ -1,3 +1,4 @@ | |||
| //nolint:dupl | |||
Owner
There was a problem hiding this comment.
Rebase branch and remove this line
internal/sbi/api_hello_test.go
Outdated
| @@ -0,0 +1,80 @@ | |||
| //nolint:dupl | |||
Owner
There was a problem hiding this comment.
Rebase branch and remove this line
internal/sbi/api_hi_test.go
Outdated
| @@ -1,3 +1,4 @@ | |||
| //nolint:dupl | |||
Owner
There was a problem hiding this comment.
Rebase branch and remove this line
Author
There was a problem hiding this comment.
vboxuser@OS2:~/proj/nf-example$ git pull origin stu/113
From https://github.com/williamlin0518/nf-example
* branch stu/113 -> FETCH_HEAD
Already up to date.
vboxuser@OS2:~/proj/nf-example$ git checkout feature/hello
Switched to branch 'feature/hello'
vboxuser@OS2:~/proj/nf-example$ git rebase stu/113
Current branch feature/hello is up to date.
similar pattern to api_chiikawa_test.go and api_hi_test.go
@andy89923 please more in detail, thanks
Owner
|
And try to squash the commits for linter fixes. |
williamlin0518
force-pushed
the
feature/hello
branch
from
c973f1d to
ce5fa79
Compare
Author
squash below commit |
andy89923
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add hello API with GET and POST endpoints and tests