Fix dashboard clicks not working on lower sidebar items #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
rowIndexAt() was not checking showKeymapHints when calculating the clickable area, but View() and visibleHeight() did check it. This caused clicks on lower items to fail bounds checks when keymap hints were hidden (the default). Added helpLineCount() helper function (matching sidebar pattern) to encapsulate the showKeymapHints check and prevent this class of bug. Refactored rowIndexAt(), View(), and visibleHeight() to use it. Added regression test and split toolbar tests to separate file to stay under 500-line limit. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andyrewlee
force-pushed
the
project-click
branch
from
e7bf3f4 to
f6ab109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rowIndexAt() was not checking showKeymapHints when calculating the clickable area, but View() and visibleHeight() did check it. This caused clicks on lower items to fail bounds checks when keymap hints were hidden (the default).
Added regression test and split toolbar tests to separate file to stay under 500-line limit.