Handle $patch directives in SMP #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyyu2004
force-pushed
the
bug-patch-delete-directive
branch
from
871a48b to
e55429d
Compare
Added tests: - volume-remove-emptydir-overlay: Tests emptyDir removal with overlay patches and configMapGenerator - remove-emptydir-same-level: Tests removing emptyDir with multiple patches at same level - null-values-1: Tests that null values in args field are preserved - null-values-2: Tests that null volumes field is preserved - name-prefix-suffix-patch: Tests patches correctly update ConfigMap references with hash suffixes (issue #2609) - patch-different-ports: Tests ports with different merge keys are merged correctly test: add failing test for $patch: delete directive The $patch: delete directive should remove a resource from the output, but currently it's being treated as a regular field in the resource. Expected: Only rule2 should remain in output Actual: Both rule1 and rule2 present, with '$patch: delete' as a field on rule1 Test for #3616. Ported from Go kustomize TestSmpDeleteOnResource.
andyyu2004
force-pushed
the
bug-patch-delete-directive
branch
from
e7b303a to
f704c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.