Skip to content

Rename parameters as async is a python3 keyword #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chuajiesheng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename parameters as async is a python3 keyword #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions angus/client/rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,12 +289,12 @@ def __init__(self, *args, **kargs):
self.default_session = None
self.session_parameters = None

def process(self, parameters=None, async=False, session=None):
def process(self, parameters=None, is_async=False, session=None):
"""Create a job configurate with

Arguments:
parameters -- the job parameter (default {})
async -- request an async job (default False)
is_async -- request an async job (default False)
session -- a session object (default None)
"""
if parameters is None:
Expand All @@ -311,19 +311,19 @@ def process(self, parameters=None, async=False, session=None):
if session is not None:
parameters['state'] = session.state()

parameters['async'] = async
parameters['async'] = is_async

job = self.jobs.create(
parameters,
resource_type=Job)
return job

def process_async(self, parameters=None, async=False, session=None):
def process_async(self, parameters=None, is_async=False, session=None):
"""Create an asynchronous job configurate with

Arguments:
parameters -- the job parameter (default {})
async -- request an async job (default False)
is_async -- request an async job (default False)
session -- a session object (default None)

Returns a Future object
Expand All @@ -342,7 +342,7 @@ def process_async(self, parameters=None, async=False, session=None):
if session is not None:
parameters['state'] = session.state()

parameters['async'] = async
parameters['async'] = is_async

fut = self.jobs.create_async(
parameters,
Expand Down