Feat: Revamp event card and add event info modal popup#244
Open
Rahulm2310 wants to merge 1 commit intoanitab-org:developfrom
Open
Feat: Revamp event card and add event info modal popup#244Rahulm2310 wants to merge 1 commit intoanitab-org:developfrom
Rahulm2310 wants to merge 1 commit intoanitab-org:developfrom
Conversation
Contributor
Author
|
@nandini45 @keshakaneria Can you please review this PR. Thanks 🙂 |
Member
|
@Rahulm2310 Can we keep 3 in a row? Currently there seems a lot of space on right and a bit on left side of card. What do you say @nandini45? |
Contributor
Author
|
@keshakaneria Yes it can be but do we need to discuss it with the design team first? |
Member
Yes, tagging @nandini45 again as a part of designing project to let us know if this can be done. |
Member
|
@Rahulm2310 could you fix the merge conflicts? I really like what you did here. Would love to get this on track again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shorten the text in the events cards, add a Read more button in the card and add a new event details modal popup to display full details of event.
Fixes #237
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only