This repository was archived by the owner on Jan 4, 2023. It is now read-only.
ensure all github projects have correct template#448
Merged
ansible-zuul[bot] merged 1 commit intoansible:masterfrom May 20, 2020
Merged
Conversation
Contributor
|
#285 was my attempt before to do this, but haven't continued with it. I feel we should adapt this script, into existing tools/zuul-projects-checks.py. I think the missing step, which you are doing, is loading the projects from zuul/tenants.yaml, over me hardcoding namespaces |
goneri
force-pushed
the
ensure-all-github-projects-have-correct-template
branch
2 times, most recently
from
a4035ad to
170f0e8
Compare
pabelanger
reviewed
May 15, 2020
pabelanger
reviewed
May 15, 2020
pabelanger
reviewed
May 15, 2020
goneri
force-pushed
the
ensure-all-github-projects-have-correct-template
branch
from
170f0e8 to
e87e101
Compare
pabelanger
reviewed
May 15, 2020
pabelanger
reviewed
May 15, 2020
| - ansible-community/pytest-molecule | ||
| - ansible/network | ||
| - ansible-network/arista_eos | ||
| - ansible-network/aws |
Contributor
There was a problem hiding this comment.
lets move this into another PR, if no longer needed. As we need to retire via github/projects.yaml
goneri
force-pushed
the
ensure-all-github-projects-have-correct-template
branch
from
e87e101 to
cbcf340
Compare
Ensure all the projects depend on `system-required` template. Consequently, correct `amazon.aws` and `ansible-bender` configuration. - `amazon.aws`: adjust the location of the repo and the default branch - `ansible-blender`: use `system-required` template Also, improve `zuul-projects-checks.py` to cover this case. - Depends on Python3 and use pathlib because it's 2020! - ensure github projects have consistent templates
goneri
force-pushed
the
ensure-all-github-projects-have-correct-template
branch
from
cbcf340 to
a6e7c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all the projects with either
noop-jobsorsystem-required.